linux-kernel - Re: [PATCH] fs/pipe: Delete unused do_pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202301111853.0Uzxdc8L-lkp@intel.com>
Date:   Wed, 11 Jan 2023 18:26:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chengming Zhou <zhouchengming@...edance.com>,
        viro@...iv.linux.org.uk
Cc:     oe-kbuild-all@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Chengming Zhou <zhouchengming@...edance.com>
Subject: Re: [PATCH] fs/pipe: Delete unused do_pipe_flags()

Hi Chengming,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.2-rc3 next-20230111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chengming-Zhou/fs-pipe-Delete-unused-do_pipe_flags/20230111-110736
patch link:    https://lore.kernel.org/r/20230111030547.7730-1-zhouchengming%40bytedance.com
patch subject: [PATCH] fs/pipe: Delete unused do_pipe_flags()
config: sparc-randconfig-r035-20230110
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ad99d13fde4e706fb2ceeeef7606be436afd204d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Chengming-Zhou/fs-pipe-Delete-unused-do_pipe_flags/20230111-110736
        git checkout ad99d13fde4e706fb2ceeeef7606be436afd204d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash arch/sparc/kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/sparc/kernel/sys_sparc_64.c: In function 'sys_sparc_pipe':
>> arch/sparc/kernel/sys_sparc_64.c:319:17: error: implicit declaration of function 'do_pipe_flags'; did you mean 'folio_flags'? [-Werror=implicit-function-declaration]
     319 |         error = do_pipe_flags(fd, 0);
         |                 ^~~~~~~~~~~~~
         |                 folio_flags
   cc1: all warnings being treated as errors


vim +319 arch/sparc/kernel/sys_sparc_64.c

a91690ddd05ab0 arch/sparc64/kernel/sys_sparc.c  David S. Miller 2006-03-17  309  
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  310  /*
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  311   * sys_pipe() is the normal C calling standard for creating
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  312   * a pipe. It's not the way unix traditionally does this, though.
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  313   */
3e3511b3c8a5ff arch/sparc/kernel/sys_sparc_64.c Al Viro         2018-03-19  314  SYSCALL_DEFINE0(sparc_pipe)
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  315  {
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  316  	int fd[2];
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  317  	int error;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  318  
ed8cae8ba01348 arch/sparc64/kernel/sys_sparc.c  Ulrich Drepper  2008-07-23 @319  	error = do_pipe_flags(fd, 0);
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  320  	if (error)
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  321  		goto out;
3e3511b3c8a5ff arch/sparc/kernel/sys_sparc_64.c Al Viro         2018-03-19  322  	current_pt_regs()->u_regs[UREG_I1] = fd[1];
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  323  	error = fd[0];
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  324  out:
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  325  	return error;
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  326  }
^1da177e4c3f41 arch/sparc64/kernel/sys_sparc.c  Linus Torvalds  2005-04-16  327  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (163473 bytes)