linux-kernel - Re: [PATCH RFC 2/3] media: uvcvideo: remove entity privacy control in the uvc video node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <350cbdd5-55bc-96b1-387e-ba9abeb26470@collabora.com>
Date:   Wed, 11 Jan 2023 11:33:07 +0100
From:   Andrzej Pietrasiewicz <andrzej.p@...labora.com>
To:     Yunke Cao <yunkec@...omium.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ricardo Ribalda <ribalda@...omium.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Cc:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH RFC 2/3] media: uvcvideo: remove entity privacy control in
 the uvc video node

Hello,

W dniu 11.01.2023 o 09:52, Yunke Cao pisze:
> For privacy_gpio, do not expose V4L2_CID_PRIVACY to userspace as a control
> of the video node.
> 

I know it is an RFC, so maybe you distribute the changes into 3 patches
on purpose. But, after applying this patch V4L2_CID_PRIVACY is lost
until it is re-implemented later, isn't it? Because of that It seems to me
patches 2/3 and 3/3 should be combined into one.

Regards,

Andrzej

> Signed-off-by: Yunke Cao <yunkec@...omium.org>
> ---
>   drivers/media/usb/uvc/uvc_ctrl.c | 17 -----------------
>   1 file changed, 17 deletions(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
> index c95a2229f4fa..77c5ff19add8 100644
> --- a/drivers/media/usb/uvc/uvc_ctrl.c
> +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> @@ -348,14 +348,6 @@ static const struct uvc_control_info uvc_ctrls[] = {
>   				| UVC_CTRL_FLAG_RESTORE
>   				| UVC_CTRL_FLAG_AUTO_UPDATE,
>   	},
> -	{
> -		.entity		= UVC_GUID_EXT_GPIO_CONTROLLER,
> -		.selector	= UVC_CT_PRIVACY_CONTROL,
> -		.index		= 0,
> -		.size		= 1,
> -		.flags		= UVC_CTRL_FLAG_GET_CUR
> -				| UVC_CTRL_FLAG_AUTO_UPDATE,
> -	},
>   };
>   
>   static const u32 uvc_control_classes[] = {
> @@ -710,15 +702,6 @@ static const struct uvc_control_mapping uvc_ctrl_mappings[] = {
>   		.v4l2_type	= V4L2_CTRL_TYPE_BOOLEAN,
>   		.data_type	= UVC_CTRL_DATA_TYPE_BOOLEAN,
>   	},
> -	{
> -		.id		= V4L2_CID_PRIVACY,
> -		.entity		= UVC_GUID_EXT_GPIO_CONTROLLER,
> -		.selector	= UVC_CT_PRIVACY_CONTROL,
> -		.size		= 1,
> -		.offset		= 0,
> -		.v4l2_type	= V4L2_CTRL_TYPE_BOOLEAN,
> -		.data_type	= UVC_CTRL_DATA_TYPE_BOOLEAN,
> -	},
>   };
>   
>   static const struct uvc_control_mapping uvc_ctrl_mappings_uvc11[] = {
>