[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e1a29bfd-7553-ec43-431e-0828191d2127@nvidia.com>
Date: Wed, 11 Jan 2023 10:35:07 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-tegra@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: u_ether: Don't warn in
gether_setup_name_default()
On 10/01/2023 16:31, Andrzej Pietrasiewicz wrote:
> Hi,
>
> Hasn't there been a similar patch already?
There could be, but I was not aware. Do you happen to have a link to it?
> W dniu 6.01.2023 o 17:17, Jon Hunter pisze:
>> The function gether_setup_name_default() is called by various USB
>> ethernet gadget drivers. This function always generates the MAC address
>> for the ethernet gadget device and always prints a warning when
>> generating the MAC address. Given that these messages are expected, make
>> these prints informational instead of warnings.
>>
>> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
>> ---
>> drivers/usb/gadget/function/u_ether.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/function/u_ether.c
>> b/drivers/usb/gadget/function/u_ether.c
>> index 8f12f3f8f6ee..c19d66cd1446 100644
>> --- a/drivers/usb/gadget/function/u_ether.c
>> +++ b/drivers/usb/gadget/function/u_ether.c
>> @@ -845,13 +845,13 @@ struct net_device
>> *gether_setup_name_default(const char *netname)
>> snprintf(net->name, sizeof(net->name), "%s%%d", netname);
>> eth_random_addr(dev->dev_mac);
>> - pr_warn("using random %s ethernet address\n", "self");
>> + pr_info("using random %s ethernet address\n", "self");
>
> As far as I can tell this function is called by all Ethernet gadgets,
> and using random Ethernet addresses is the default behavior for all of
> them,
> including legacy gadgets. Why to inform about the default situation
> happening?
> So in fact maybe it would be better to eliminate the pr_warn() altogether,
> instead of replacing it with pr_info()? If the user does not care to
> explicitly set some non-default address(es), why would she care to know
> that a randomly selected address has been chosen? Note that learning
> _what_ specific address has been chosen is perfectly doable without
> these pr_info() calls.
That would be fine with me. This print has been there for a long time
and so I figured people wanted some sort of message. I would be happy to
remove.
Jon
--
nvpublic
Powered by blists - more mailing lists