linux-kernel - Re: [PATCHv4 linux-next 3/4] Rockchip RV1126 has GMAC 10/100/1000M ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2917690.KRxA6XjA2N@diego>
Date:   Wed, 11 Jan 2023 11:43:42 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Anand Moon <anand@...eble.ai>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Richard Cochran <richardcochran@...il.com>,
        Johan Jonker <jbx6244@...il.com>,
        Jagan Teki <jagan@...eble.ai>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCHv4 linux-next 3/4] Rockchip RV1126 has GMAC 10/100/1000M ethernet controller

Am Mittwoch, 11. Januar 2023, 11:31:40 CET schrieb Anand Moon:
> Hi Heiko,
> 
> Thanks for your review comments.
> 
> On Wed, 11 Jan 2023 at 15:41, Heiko Stübner <heiko@...ech.de> wrote:
> >
> > Hi,
> >
> > Am Mittwoch, 11. Januar 2023, 07:48:38 CET schrieb Anand Moon:
> > > Add Ethernet GMAC node for RV1126 SoC.
> > >
> > > Signed-off-by: Anand Moon <anand@...eble.ai>
> > > Signed-off-by: Jagan Teki <jagan@...eble.ai>
> >
> > patches 2-4 have this Signed-off-by from Jagan again where he is not
> > not the author but also not the sender.
> 
> We both work to fix this patch hence Jagan's SoB was added.

ok, then I think the correct way to express that would be:

Co-Developed-by: Jagan Teki <jagan@...eble.ai>
Signed-off-by: Jagan Teki <jagan@...eble.ai>
Signed-off-by: Anand Moon <anand@...eble.ai>


> >
> > Also this patch here, needs a fixed subject with the correct prefixes.
> >
> Ok, will fix this in the next version.
> >
> > Heiko
> >
> > > ---
> > > v4: sort the node as reg adds. update the commit message.
> > > v3: drop the gmac_clkin_m0 & gmac_clkin_m1 fix clock node which are not
> > >     used, Add SoB of Jagan Teki.
> > > v2: drop SoB of Jagan Teki.
> 
> Thanks
> -Anand
>