linux-kernel - Re: [PATCH] thermal/drivers/qcom: Remove duplicate set next trip point interrupt code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a315e420-5fa4-21c4-e297-42480ebfa2bd@linaro.org>
Date:   Wed, 11 Jan 2023 12:24:58 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Bjorn Andersson <andersson@...nel.org>
Cc:     rafael@...nel.org, dmitry.baryshkov@...aro.org,
        konrad.dybcio@...aro.org, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        Andy Gross <agross@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thermal/drivers/qcom: Remove duplicate set next trip
 point interrupt code

On 10/01/2023 19:13, Bjorn Andersson wrote:
> On Tue, Jan 10, 2023 at 11:34:20AM +0100, Daniel Lezcano wrote:
>> From: Daniel Lezcano <daniel.lezcano@...aro.org>
>>
>> The tsens driver reprogram the next trip points in the irq
>> handler. This function then call thermal_zone_device_update().
>>
>> However, thermal_zone_device_update() calls thermal_zone_set_trips()
>> and from there it calls the backend 'set_trips' ops. This one in turn
>> reprogram the next trip points (low/high).
>>
>> Consequently, the code setting the next trip points interrupt in the
>> interrupt handle is not needed and could be removed.
>>
> 
> 
> Reviewed-by: Bjorn Andersson <andersson@...nel.org>
> 
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...nel.org>
> 
> The last one should be the address you sent your patch from, and that
> was the first one. So I think you should drop this one.

Thanks for the review. I'll remove the duplicated SoB.

   -- Daniel


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog