[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230111113301.GC4873@thinkpad>
Date: Wed, 11 Jan 2023 17:03:01 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: andersson@...nel.org, krzysztof.kozlowski+dt@...aro.org,
bhelgaas@...gle.com, konrad.dybcio@...aro.org,
linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
lpieralisi@...nel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: PCI: qcom: Document msi-map and
msi-map-mask properties
On Sun, Jan 08, 2023 at 02:33:40PM -0600, Rob Herring wrote:
> On Mon, Jan 02, 2023 at 04:28:20PM +0530, Manivannan Sadhasivam wrote:
> > The Qcom PCIe controller is capable of using either internal MSI controller
> > or the external GIC-ITS for signaling MSIs sent by endpoint devices.
> > Currently, the binding only documents the internal MSI implementation.
> >
> > Let's document the GIC-ITS imeplementation by making use of msi-map and
> > msi-map-mask properties. Only one of the implementation should be used
> > at a time.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > ---
> > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > index a3639920fcbb..01208450e05c 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > @@ -114,14 +114,20 @@ required:
> > - compatible
> > - reg
> > - reg-names
> > - - interrupts
> > - - interrupt-names
> > - - "#interrupt-cells"
> > - interrupt-map-mask
> > - interrupt-map
> > - clocks
> > - clock-names
> >
> > +oneOf:
>
> anyOf
>
> The OS should have the option of both being present and pick which MSI
> path it wants to use.
>
Makes sense. Given that the current series merged by Bjorn, I'll send a
follow-up patch.
Thanks,
Mani
> Rob
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists