linux-kernel - Re: [PATCH v2] KVM: s390: interrupt: use READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y76nb+2tTERSszfP@osiris>
Date:   Wed, 11 Jan 2023 13:11:27 +0100
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Christian Borntraeger <borntraeger@...ux.ibm.com>
Cc:     Janosch Frank <frankja@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] KVM: s390: interrupt: use READ_ONCE() before cmpxchg()

On Tue, Jan 10, 2023 at 08:15:50PM +0100, Christian Borntraeger wrote:
> Am 09.01.23 um 15:54 schrieb Heiko Carstens:
> > Use READ_ONCE() before cmpxchg() to prevent that the compiler generates
> > code that fetches the to be compared old value several times from memory.
> > 
> > Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> 
> Looks sane.
> 
> Reviewed-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> 
> In case you want to take it via the s390 tree:
> Acked-by: Christian Borntraeger <borntraeger@...ux.ibm.com>

Given that there don't seem to be any pending s390 specific patches I
take it via the s390 tree.

Applied.