linux-kernel - Re: [PATCH] pstore/ram: Rework logic for detecting ramoops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <217ebecf-3630-b423-ea0b-037e0943e17b@igalia.com>
Date:   Wed, 11 Jan 2023 10:01:03 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     Mukesh Ojha <quic_mojha@...cinc.com>, keescook@...omium.org,
        tony.luck@...el.com
Cc:     linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pstore/ram: Rework logic for detecting ramoops

Thanks for the patch Mukesh! I don't have a DT hardware at hand right
now, so cannot test this one myself. I'll just provide a (really) minor
feedback, something to address in a potential V2 or even in merge time,
see below.


On 11/01/2023 06:07, Mukesh Ojha wrote:
> The reserved memory region for ramoops is assumed to be at a fixed
> and known location when read from the devicetree. This is not desirable
> in environments where it is preferred the region to be dynamically
> allocated at runtime, as opposed to being fixed at compile time.
> 
> Also, Some of the platforms might be still expecting dedicated

I'd write "Also, some" instead of upper "Some".

> memory region for ramoops node where the region is known
> beforehand and platform_get_resource() is used in that case.
> 
> So, Add logic to detect the start and size of the ramoops memory

Same here, maybe "So, add".

Really minor nits, though!
Cheers,


Guilherme