[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c8c887f-3935-77e6-9d0e-283226ad357c@gmail.com>
Date: Wed, 11 Jan 2023 14:29:32 +0100
From: Maximilian Luz <luzmaximilian@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2 03/16] platform/surface: aggregator: move
to_ssam_device() to use container_of_const()
On 1/11/23 13:14, Greg Kroah-Hartman wrote:
> On Wed, Jan 11, 2023 at 01:02:01PM +0100, Maximilian Luz wrote:
>> On 1/11/23 12:30, Greg Kroah-Hartman wrote:
>>> The driver core is changing to pass some pointers as const, so move
>>> to_ssam_device() to use container_of_const() to handle this change.
>>> to_ssam_device() now properly keeps the const-ness of the pointer passed
>>> into it, while as before it could be lost.
>>>
>>> Cc: Maximilian Luz <luzmaximilian@...il.com>
>>> Cc: platform-driver-x86@...r.kernel.org
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>>> ---
>>> include/linux/surface_aggregator/device.h | 5 +----
>>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>> diff --git a/include/linux/surface_aggregator/device.h b/include/linux/surface_aggregator/device.h
>>> index 46c45d1b6368..24151a0e2c96 100644
>>> --- a/include/linux/surface_aggregator/device.h
>>> +++ b/include/linux/surface_aggregator/device.h
>>> @@ -229,10 +229,7 @@ static inline bool is_ssam_device(struct device *d)
>>> * Return: Returns a pointer to the &struct ssam_device wrapping the given
>>> * device @d.
>>> */
>>> -static inline struct ssam_device *to_ssam_device(struct device *d)
>>> -{
>>> - return container_of(d, struct ssam_device, dev);
>>> -}
>>> +#define to_ssam_device(d) container_of_const(d, struct ssam_device, dev)
>>> /**
>>> * to_ssam_device_driver() - Casts the given device driver to a SSAM client
>>
>> A small note in addition to the comment by Hans: I think it might be a
>> good idea to convert the to_ssam_device_driver() function as well. I
>> could also send this in as a follow-up patch.
>
> Sure, that can be a follow-on patch as it's not needed here.
Perfect, I'll do that.
As Hans' comment is now addressed, everything looks good to me.
Reviewed-by: Maximilian Luz <luzmaximilian@...il.com>
Powered by blists - more mailing lists