linux-kernel - Re: [PATCH] f2fs: convert discard_wake and gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <732e4696-5349-fb3b-87e5-8f0ecf368571@kernel.org>
Date:   Wed, 11 Jan 2023 21:37:14 +0800
From:   Chao Yu <chao@...nel.org>
To:     Yangtao Li <frank.li@...o.com>, jaegeuk@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: convert discard_wake and gc_wake to bool type

On 2022/12/12 21:36, Yangtao Li wrote:
> discard_wake and gc_wake have only two values, 0 or 1.
> So there is no need to use int type to store them.
> 
> BTW, move discard_wake to the end of the
> discard_cmd_control structure.
> 
> Before:
> 
>    - sizeof(struct discard_cmd_control): 8392
> 
> After move:
> 
>    - sizeof(struct discard_cmd_control): 8384
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,