linux-kernel - Re: [PATCH v2] lpfc: Handle gracefully failed FLOGI attempts in devloss callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230111140850.cww4xgq5vtvrt6kx@carbon.lan>
Date:   Wed, 11 Jan 2023 15:08:50 +0100
From:   Daniel Wagner <dwagner@...e.de>
To:     James Smart <jsmart2021@...il.com>
Cc:     Dick Kennedy <dick.kennedy@...adcom.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lpfc: Handle gracefully failed FLOGI attempts in
 devloss callback

On Wed, Jan 11, 2023 at 12:38:41PM +0100, Daniel Wagner wrote:
> When FLOGI attempts fail, the vport can be released via
> lpfc_nlp_release() function. This function will set the pointer to NULL
> and the node state to NLP_STE_FREED_NODE. Though it wont stop the
> devloss timer in the upper SCSI layer.
> 
> Hence when the devloss timer eventually fires,
> lpfc_dev_loss_tmo_callbk() is called and it tries to operate on vport
> NULL pointer.
> 
> Just do nothing in this case. To be extra cautions also check for the
> state and issue a warning if we have an inconsistency.

Ignore this one. Just saw the proper fix:

https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=97f256913c5d