linux-kernel - Re: [PATCH v5 1/5] x86/cpufeature: add the cpu feature bit for LKGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2023 15:27:39 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Xin Li <xin3.li@...el.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, dave.hansen@...ux.intel.com, hpa@...or.com,
        peterz@...radead.org, brgerst@...il.com, chang.seok.bae@...el.com,
        jgross@...e.com
Subject: Re: [PATCH v5 1/5] x86/cpufeature: add the cpu feature bit for LKGS

On Mon, Nov 28, 2022 at 08:40:24AM -0800, Xin Li wrote:
> From: "H. Peter Anvin (Intel)" <hpa@...or.com>
> 
> Add the CPU feature bit for LKGS (Load "Kernel" GS).
> 
> LKGS instruction is introduced with Intel FRED (flexible return and
> event delivery) specificaton

Unknown word [specificaton] in commit message.
Suggestions: ['specification',

Please use a spellchecker for your commit messages.

> https://cdrdv2.intel.com/v1/dl/getContent/678938.

This URL is most likely going to be unstable.

Write instead

"Search for the latest spec in most search engines by doing:

site:intel.com FRED (flexible return and event delivery) specification"

Google etc has indexed it already so it should always pull out the newest
revision.

$ test-apply.sh /tmp/01-x86-cpufeature-add_the_cpu_feature_bit_for_lkgs-new.patch
checking file arch/x86/include/asm/cpufeatures.h
Hunk #1 FAILED at 311.
1 out of 1 hunk FAILED
checking file tools/arch/x86/include/asm/cpufeatures.h
Hunk #1 FAILED at 308.
1 out of 1 hunk FAILED
Apply? (y/n)

I guess you'd need to refresh the patchset against latest tip/master.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette