linux-kernel - Re: [PATCH] io_uring: Add NULL checks for current->io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63d8e95e-894c-4268-648e-35e504ea80b6@kernel.dk>
Date:   Wed, 11 Jan 2023 07:49:30 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Jia-Ju Bai <baijiaju1990@...il.com>, asml.silence@...il.com
Cc:     io-uring@...r.kernel.org, linux-kernel@...r.kernel.org,
        TOTE Robot <oslab@...nghua.edu.cn>
Subject: Re: [PATCH] io_uring: Add NULL checks for current->io_uring

On 1/11/23 3:19 AM, Jia-Ju Bai wrote:
> As described in a previous commit 998b30c3948e, current->io_uring could
> be NULL, and thus a NULL check is required for this variable.
> 
> In the same way, other functions that access current->io_uring also
> require NULL checks of this variable.

This seems odd. Have you actually seen traces of this, or is it just
based on "guess it can be NULL sometimes, check it in all spots"?

-- 
Jens Axboe