[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y77XhV0oLEyRqa2r@alley>
Date: Wed, 11 Jan 2023 16:36:37 +0100
From: Petr Mladek <pmladek@...e.com>
To: John Ogness <john.ogness@...utronix.de>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
Steven Rostedt <rostedt@...dmis.org>,
Thomas Gleixner <tglx@...utronix.de>,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH printk v5 0/8] printk: cleanup buffer handling
On Mon 2023-01-09 16:10:52, Petr Mladek wrote:
> On Mon 2023-01-09 11:13:52, John Ogness wrote:
> > Hi,
> >
> > This is v5 of a series to cleanup console buffer handling and
> > prepare for code sharing with the upcoming threaded/atomic
> > consoles. v4 is here [0].
> >
> > The main purpose of the series is to introduce two new lockless
> > functions to handle reading and formatting of printk messages. These
> > functions can then be used from any context, which is important for
> > the upcoming threaded/atomic consoles. The series also helps to
> > cleanup some of the internal printk interfaces and cleanly separate
> > formatting code from outputting code.
> >
> > Changes since v4:
> >
> > - Make console_prepend_dropped() a NOP for !CONFIG_PRINTK to
> > workaround compiler warnings.
> >
> > - In devkmsg_read() use printk_get_next_message() for the wait
> > condition instead of looping to retry the actual read.
> >
> > - Add an argument @may_suppress to printk_get_next_message() so
> > devkmsg_read() can specify that records should not be skipped
> > based on loglevel.
> >
> > John Ogness
> >
> > [0] https://lore.kernel.org/lkml/20230105103735.880956-1-john.ogness@linutronix.de
> >
> > John Ogness (6):
> > printk: move size limit macros into internal.h
> > printk: introduce struct printk_buffers
> > printk: introduce printk_get_next_message() and printk_message
> > printk: introduce console_prepend_dropped() for dropped messages
> > printk: use printk_buffers for devkmsg
> > printk: adjust string limit macros
> >
> > Thomas Gleixner (2):
> > console: Use BIT() macros for @flags values
> > console: Document struct console
>
> The series looks ready for linux-next from my POV.
>
> I am going to push it into a new branch rework/buffers-cleanup within
> two days or so unless anyone speak against it.
JFYI, the patchset has been committed into printk/linux.git,
branch rework/buffers-cleanup.
It it intended for the next 6.3 merge window.
Best Regards,
Petr
Powered by blists - more mailing lists