linux-kernel - Re: [PATCH 04/27] ARM: pxa: drop pxa310/pxa320/pxa93x support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2k01rhchf.fsf@free.fr>
Date:   Thu, 12 Jan 2023 18:37:32 +0100
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Robert Jarzmik <robert.jarzmik@...e.fr>,
        Arnd Bergmann <arnd@...nel.org>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        linux-clk@...r.kernel.org, linux-pm@...r.kernel.org,
        "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 04/27] ARM: pxa: drop pxa310/pxa320/pxa93x support


"Arnd Bergmann" <arnd@...db.de> writes:

> Hi Robert,
Hi Arnd,

> Thanks for pointing this out, I thought that I had caught
> all the missing dependencies ones after you pointed out
> the AC97_BUS_NEW that I fixed in patch 14.
Sorry I've not seen this one in my previous review.

> From what I can tell, commit b5aaaa666a85 ("ARM: pxa: add
> Kconfig dependencies for ATAGS based boards"), the
> PXA310/PXA320 DT support became dead code because
> MACH_PXA3XX_DT only selects CPU_PXA300, so if it worked
> before that commit, it now needs CONFIG_UNUSED_BOARD_FILES
> and CONFIG_EXPERT as well as enabling one of the legacy
> board files with the corresponding chip support.
>
> If that's all you think is missing, I can add this
> trivial patch as well and rework the series to not
> drop code that depends on PXA310/PXA320:
Yes, that would be great !

> Can you have a look at the other patches to see if there
> are more removed drivers or platform bits that are currently
> dead code but are actually required?
Yes, I've been through your whole serie and that's the
last thing I have identified. I've read carefully all the
patches now, and the whole serie looks good to me.

So with this patch and keeping the clocks and cpufreq
parts for pxa3*0, you can add everywhere my :

Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Cheers.

--
Robert