linux-kernel - Re: [PATCH] arm64: dts: qcom: sc8280xp: Vote for CX in USB controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 19:00:29 +0200
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Andersson <quic_bjorande@...cinc.com>,
        Bjorn Andersson <andersson@...nel.org>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Vote for CX in USB controllers

12 января 2023 г. 16:21:14 GMT+02:00, Konrad Dybcio <konrad.dybcio@...aro.org> пишет:
>
>
>On 12.01.2023 14:51, Bjorn Andersson wrote:
>> Running GCC_USB30_*_MASTER_CLK at 200MHz requires CX at nominal level,
>> not doing so results in occasional lockups. This was previously hidden
>> by the fact that the display stack incorrectly voted for CX (instead of
>> MMCX).
>> 
>> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
>> Signed-off-by: Bjorn Andersson <quic_bjorande@...cinc.com>
>> ---https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blob/LV.AU.1.2.3.r1-03600-gen3meta.0/drivers/clk/qcom/gcc-direwolf.c#L2703-2725
>
>Maybe in the future there could be some power savings for lower freqs..

I had the same question. If the vote is not static, but depends on the freq, shouldn't this be to implemented as an opp + table?


>
>Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>
>Konrad
>>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> index 2ed17baf50d3..4f4353f84cba 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> @@ -2265,6 +2265,7 @@ usb_0: usb@...8800 {
>>  					  "ss_phy_irq";
>>  
>>  			power-domains = <&gcc USB30_PRIM_GDSC>;
>> +			required-opps = <&rpmhpd_opp_nom>;
>>  
>>  			resets = <&gcc GCC_USB30_PRIM_BCR>;
>>  
>> @@ -2319,6 +2320,7 @@ usb_1: usb@...8800 {
>>  					  "ss_phy_irq";
>>  
>>  			power-domains = <&gcc USB30_SEC_GDSC>;
>> +			required-opps = <&rpmhpd_opp_nom>;
>>  
>>  			resets = <&gcc GCC_USB30_SEC_BCR>;
>>