linux-kernel - Re: [PATCH v2 12/12] staging: media: rkvdec: Add HEVC backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301130224.kAHVtIaG-lkp@intel.com>
Date:   Fri, 13 Jan 2023 02:27:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sebastian Fricke <sebastian.fricke@...labora.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-staging@...ts.linux.dev, Jonas Karlman <jonas@...boo.se>,
        Alex Bee <knaerzche@...il.com>,
        Nicolas Dufresne <nicolas.dufresne@...labora.com>,
        Collabora Kernel-domain <kernel@...labora.com>,
        Robert Beckett <bob.beckett@...labora.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        Sebastian Fricke <sebastian.fricke@...labora.com>
Subject: Re: [PATCH v2 12/12] staging: media: rkvdec: Add HEVC backend

Hi Sebastian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 6599e683db1bf22fee74302c47e31b9a42a1c3d2]

url:    https://github.com/intel-lab-lkp/linux/commits/Sebastian-Fricke/media-v4l2-Add-NV15-pixel-format/20230112-205935
base:   6599e683db1bf22fee74302c47e31b9a42a1c3d2
patch link:    https://lore.kernel.org/r/20230101-patch-series-v2-6-2-rc1-v2-12-fa1897efac14%40collabora.com
patch subject: [PATCH v2 12/12] staging: media: rkvdec: Add HEVC backend
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b09b88f41bd2c6bf802598f997e4fc2d5048456a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sebastian-Fricke/media-v4l2-Add-NV15-pixel-format/20230112-205935
        git checkout b09b88f41bd2c6bf802598f997e4fc2d5048456a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/staging/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/staging/media/rkvdec/rkvdec-hevc.c: In function 'rotate_and_flatten_matrices':
>> drivers/staging/media/rkvdec/rkvdec-hevc.c:476:83: warning: variable 'new_value' set but not used [-Wunused-but-set-variable]
     476 |         int i, j, row, x_offset, matrix_offset, rot_index, y_offset, matrix_size, new_value;
         |                                                                                   ^~~~~~~~~


vim +/new_value +476 drivers/staging/media/rkvdec/rkvdec-hevc.c

   464	
   465	/*
   466	 * Flip one or more matrices along their main diagonal and flatten them
   467	 * before writing it to the memory.
   468	 * Convert:
   469	 * ABCD         AEIM
   470	 * EFGH     =>  BFJN     =>     AEIMBFJNCGKODHLP
   471	 * IJKL         CGKO
   472	 * MNOP         DHLP
   473	 */
   474	static void rotate_and_flatten_matrices(u8 *output, const u8 *input, int matrices, int row_length)
   475	{
 > 476		int i, j, row, x_offset, matrix_offset, rot_index, y_offset, matrix_size, new_value;
   477	
   478		matrix_size = row_length * row_length;
   479		for (i = 0; i < matrices; i++) {
   480			row = 0;
   481			x_offset = 0;
   482			matrix_offset = i * matrix_size;
   483			for (j = 0; j < matrix_size; j++) {
   484				y_offset = j - (row * row_length);
   485				rot_index = y_offset * row_length + x_offset;
   486				new_value = *(input + i * matrix_size + j);
   487				output[matrix_offset + rot_index] = *(input + i * matrix_size + j);
   488				if ((j + 1) % row_length == 0) {
   489					row += 1;
   490					x_offset += 1;
   491				}
   492			}
   493		}
   494	}
   495	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (278718 bytes)