[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230112043908.2938964-1-wenst@chromium.org>
Date: Thu, 12 Jan 2023 12:39:08 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Benson Leung <bleung@...omium.org>,
Guenter Roeck <groeck@...omium.org>,
Tzung-Bi Shih <tzungbi@...nel.org>
Cc: Chen-Yu Tsai <wenst@...omium.org>, chrome-platform@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: [PATCH] platform/chrome: cros_ec: Initialize panic notifier block
Commit d90fa2c64d59 ("platform/chrome: cros_ec: Poll EC log on EC panic")
added a new notifier block, but failed to initialize it properly,
resulting in a warning and stack trace (omitted):
INFO: trying to register non-static key.
The code is fine but needs lockdep annotation, or maybe
you didn't initialize this object before use?
turning off the locking correctness validator.
Initialize the notifier block properly.
Fixes: d90fa2c64d59 ("platform/chrome: cros_ec: Poll EC log on EC panic")
Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
---
drivers/platform/chrome/cros_ec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 4ae57820afd5..b895c8130bba 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -182,6 +182,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
int err = 0;
BLOCKING_INIT_NOTIFIER_HEAD(&ec_dev->event_notifier);
+ BLOCKING_INIT_NOTIFIER_HEAD(&ec_dev->panic_notifier);
ec_dev->max_request = sizeof(struct ec_params_hello);
ec_dev->max_response = sizeof(struct ec_response_get_protocol_info);
--
2.39.0.314.g84b9a713c41-goog
Powered by blists - more mailing lists