linux-kernel - Re: [PATCH v1 1/2] pinctrl: bcm: bcm2835: Switch to use ->add_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301130741.n6fa0GWC-lkp@intel.com>
Date:   Fri, 13 Jan 2023 07:30:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/2] pinctrl: bcm: bcm2835: Switch to use
 ->add_pin_ranges()

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on linusw-pinctrl/devel linusw-pinctrl/for-next linus/master v6.2-rc3 next-20230112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpiolib-of-Remove-no-more-used-of_gpio_ranges_fallback/20230113-005102
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20230112163825.72983-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/2] pinctrl: bcm: bcm2835: Switch to use ->add_pin_ranges()
config: csky-randconfig-r033-20230112
compiler: csky-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/bdb795cd895842fc4e482dc4131406e9534738fd
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/gpiolib-of-Remove-no-more-used-of_gpio_ranges_fallback/20230113-005102
        git checkout bdb795cd895842fc4e482dc4131406e9534738fd
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash drivers/pinctrl/bcm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/pinctrl/bcm/pinctrl-bcm2835.c: In function 'bcm2835_add_pin_ranges_fallback':
>> drivers/pinctrl/bcm/pinctrl-bcm2835.c:364:58: error: invalid use of undefined type 'struct gpio_device'
     364 |         struct device_node *np = dev_of_node(&gc->gpiodev->dev);
         |                                                          ^~
   drivers/pinctrl/bcm/pinctrl-bcm2835.c:363:33: warning: unused variable 'pc' [-Wunused-variable]
     363 |         struct bcm2835_pinctrl *pc = gpiochip_get_data(gc);
         |                                 ^~


vim +364 drivers/pinctrl/bcm/pinctrl-bcm2835.c

   360	
   361	static int bcm2835_add_pin_ranges_fallback(struct gpio_chip *gc)
   362	{
   363		struct bcm2835_pinctrl *pc = gpiochip_get_data(gc);
 > 364		struct device_node *np = dev_of_node(&gc->gpiodev->dev);
   365		struct pinctrl_dev *pctldev = of_pinctrl_get(np);
   366	
   367		if (!pctldev)
   368			return 0;
   369	
   370		if (of_property_read_bool(np, "gpio-ranges"))
   371			return 0;
   372	
   373		gpiochip_add_pin_range(gc, pinctrl_dev_get_devname(pctldev), 0, 0,
   374				       gc->ngpio);
   375	
   376		return 0;
   377	}
   378	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (140065 bytes)