| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAA8EJpqXwoFvr08oH1VKnNef1nuuysBUxD+nJE_7LWjY0sCLUQ@mail.gmail.com>
Date: Thu, 12 Jan 2023 07:27:06 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Pin-yen Lin <treapking@...omium.org>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <robert.foss@...aro.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>,
Jernej Skrabec <jernej.skrabec@...il.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Daniel Scally <djrscally@...il.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Prashant Malani <pmalani@...omium.org>,
Benson Leung <bleung@...omium.org>,
Guenter Roeck <groeck@...omium.org>,
Marek Vasut <marex@...x.de>, devicetree@...r.kernel.org,
linux-acpi@...r.kernel.org,
Nícolas F . R . A . Prado
<nfraprado@...labora.com>, chrome-platform@...ts.linux.dev,
linux-kernel@...r.kernel.org, Hsin-Yi Wang <hsinyi@...omium.org>,
Javier Martinez Canillas <javierm@...hat.com>,
dri-devel@...ts.freedesktop.org,
Stephen Boyd <swboyd@...omium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Allen Chen <allen.chen@....com.tw>,
Xin Ji <xji@...logixsemi.com>,
Chen-Yu Tsai <wenst@...omium.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v10 4/9] dt-bindings: display: bridge: anx7625: Add
mode-switch support
On Thu, 12 Jan 2023 at 07:26, Pin-yen Lin <treapking@...omium.org> wrote:
>
> Hi Dmitry,
>
> Thanks for the review.
>
> On Thu, Jan 12, 2023 at 12:43 PM Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> wrote:
> >
> > On 12/01/2023 06:20, Pin-yen Lin wrote:
> > > Analogix 7625 can be used in systems to switch the DP traffic between
> > > two downstreams, which can be USB Type-C DisplayPort alternate mode
> > > lane or regular DisplayPort output ports.
> > >
> > > Update the binding to accommodate this usage by introducing a
> > > data-lanes and a mode-switch property on endpoints.
> > >
> > > Also include the link to the product brief in the bindings.
> > >
> > > Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>
> > > Tested-by: Chen-Yu Tsai <wenst@...omium.org>
> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > >
> > > ---
> > >
> > > Changes in v10:
> > > - Collected Reviewed-by and Tested-by tags
> > >
> > > Changes in v9:
> > > - Collected Reviewed-by tag
> > >
> > > Changes in v8:
> > > - Updated anx7625 bindings for data-lane property
> > > - Fixed the subject prefix
> > >
> > > Changes in v7:
> > > - Fixed issues reported by dt_binding_check
> > > - Updated the schema and the example dts for data-lanes.
> > > - Changed to generic naming for the example dts node.
> > >
> > > Changes in v6:
> > > - Remove switches node and use endpoints and data-lanes property to
> > > describe the connections.
> > >
> > > .../display/bridge/analogix,anx7625.yaml | 99 ++++++++++++++++++-
> > > 1 file changed, 96 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > index 4590186c4a0b..b49a350c40e3 100644
> > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > @@ -12,7 +12,8 @@ maintainers:
> > >
> > > description: |
> > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> > > - designed for portable devices.
> > > + designed for portable devices. Product brief is available at
> > > + https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf
> > >
> > > properties:
> > > compatible:
> > > @@ -112,10 +113,48 @@ properties:
> > > data-lanes: true
> > >
> > > port@1:
> > > - $ref: /schemas/graph.yaml#/properties/port
> > > + $ref: /schemas/graph.yaml#/$defs/port-base
> > > description:
> > > Video port for panel or connector.
> > >
> > > + patternProperties:
> > > + "^endpoint@[01]$":
> > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base
> > > + unevaluatedProperties: false
> > > +
> > > + properties:
> > > + reg:
> > > + maxItems: 1
> >
> > Please remove duplicates to the graph.yaml. You have several of them here.
>
> I'll fix this in v11.
> >
> > > +
> > > + remote-endpoint: true
> > > +
> > > + data-lanes:
> > > + oneOf:
> > > + - items:
> > > + - enum: [0, 1, 2, 3]
> > > +
> > > + - items:
> > > + - const: 0
> > > + - const: 1
> > > +
> > > + - items:
> > > + - const: 2
> > > + - const: 3
> > > +
> > > + - items:
> > > + - const: 0
> > > + - const: 1
> > > + - const: 2
> > > + - const: 3
> > > +
> > > + mode-switch:
> > > + type: boolean
> > > + description: Register this node as a Type-C mode switch or not.
> > > +
> > > + required:
> > > + - reg
> > > + - remote-endpoint
> > > +
> > > required:
> > > - port@0
> > > - port@1
> > > @@ -164,8 +203,12 @@ examples:
> > > };
> > >
> > > mipi2dp_bridge_out: port@1 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > reg = <1>;
> > > - anx7625_out: endpoint {
> > > + anx7625_out: endpoint@0 {
> >
> > But why? It's perfectly fine from the graph perspective to omit the
> > index if there is jus a single endpoint.
>
> This is because "reg" property is added as a required property. Do you
> suggest making "reg" property optional and only add it when there are
> multiple ports?
Yes. I think it makes sense.
> >
> > > + reg = <0>;
> > > remote-endpoint = <&panel_in>;
> > > };
> > > };
> > > @@ -186,3 +229,53 @@ examples:
> > > };
> > > };
> > > };
> > > + - |
> > > + i2c3 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + encoder@58 {
> > > + compatible = "analogix,anx7625";
> > > + reg = <0x58>;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&anx7625_dp_pins>;
> > > + enable-gpios = <&pio 176 GPIO_ACTIVE_HIGH>;
> > > + reset-gpios = <&pio 177 GPIO_ACTIVE_HIGH>;
> > > + vdd10-supply = <&pp1100_dpbrdg>;
> > > + vdd18-supply = <&pp1800_dpbrdg_dx>;
> > > + vdd33-supply = <&pp3300_dpbrdg_dx>;
> > > + analogix,audio-enable;
> > > +
> > > + ports {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + port@0 {
> > > + reg = <0>;
> > > + anx7625_dp_in: endpoint {
> > > + bus-type = <7>;
> > > + remote-endpoint = <&dpi_out>;
> > > + };
> > > + };
> > > +
> > > + port@1 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + reg = <1>;
> > > + anx_typec0: endpoint@0 {
> > > + reg = <0>;
> > > + mode-switch;
> > > + data-lanes = <0 1>;
> > > + remote-endpoint = <&typec_port0>;
> > > + };
> > > + anx_typec1: endpoint@1 {
> > > + reg = <1>;
> > > + mode-switch;
> > > + data-lanes = <2 3>;
> > > + remote-endpoint = <&typec_port1>;
> > > + };
> > > + };
> > > + };
> > > + };
> > > + };
> >
> > --
> > With best wishes
> > Dmitry
> >
>
> Best regards,
> Pin-yen
--
With best wishes
Dmitry
Powered by blists - more mailing lists