linux-kernel - RE: [PATCH 0/2] PCI: Fix extended config space regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB40920805703B4B8485A0450DF2FD9@DM6PR11MB4092.namprd11.prod.outlook.com>
Date:   Thu, 12 Jan 2023 05:50:32 +0000
From:   "Sun, Yunying" <yunying.sun@...el.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
CC:     "Williams, Dan J" <dan.j.williams@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Box, David E" <david.e.box@...el.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "Mika Westerberg" <mika.westerberg@...ux.intel.com>,
        "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "Hans de Goede" <hdegoede@...hat.com>,
        Florent DELAHAYE <linuxkernelml@...ead.fr>,
        Konrad J Hambrick <kjhambrick@...il.com>,
        Matt Hansen <2lprbe78@...k.com>,
        Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>,
        Benoit Grégoire <benoitg@...us.ca>,
        Werner Sembach <wse@...edocomputers.com>,
        "mumblingdrunkard@...tonmail.com" <mumblingdrunkard@...tonmail.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: RE: [PATCH 0/2] PCI: Fix extended config space regression

With this updated patches, perf uncore works fine on SPR(tested on both DNP and MCC).

Tested-by: Yunying Sun <yunying.sun@...el.com>

-----Original Message-----
From: Bjorn Helgaas <helgaas@...nel.org> 
Sent: Wednesday, 11 January, 2023 02:03
To: linux-pci@...r.kernel.org
Cc: Williams, Dan J <dan.j.williams@...el.com>; Kan Liang <kan.liang@...ux.intel.com>; Luck, Tony <tony.luck@...el.com>; Box, David E <david.e.box@...el.com>; Sun, Yunying <yunying.sun@...el.com>; Jiang, Dave <dave.jiang@...el.com>; Mika Westerberg <mika.westerberg@...ux.intel.com>; Cabiddu, Giovanni <giovanni.cabiddu@...el.com>; Herbert Xu <herbert@...dor.apana.org.au>; Hans de Goede <hdegoede@...hat.com>; Florent DELAHAYE <linuxkernelml@...ead.fr>; Konrad J Hambrick <kjhambrick@...il.com>; Matt Hansen <2lprbe78@...k.com>; Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>; Benoit Grégoire <benoitg@...us.ca>; Werner Sembach <wse@...edocomputers.com>; mumblingdrunkard@...tonmail.com; linux-kernel@...r.kernel.org; Bjorn Helgaas <bhelgaas@...gle.com>
Subject: [PATCH 0/2] PCI: Fix extended config space regression

From: Bjorn Helgaas <bhelgaas@...gle.com>

07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map") appeared in v6.2-rc1 and broke extended config space on several machines.

This broke drivers that use things in extended config space, e.g., perf, VSEC telemetry, EDAC, QAT, etc.

This happened because mmconfig-shared.c checks to see that ECAM space is reserved in E820 or ACPI motherboard resources.  If it's not, it assumes ECAM doesn't work.  07eab0901ede removed some E820 entries, so it looked like ECAM was no longer reserved, so we stopped using it.

The machines where this broke don't reserve the ECAM in ACPI PNP0C02 devices (which seems to be what the PCI Firmware spec requires), but they do mention it in the EFI memory map as EfiMemoryMappedIO.

Bjorn Helgaas (2):
  x86/pci: Simplify is_mmconf_reserved() messages
  x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space

 arch/x86/pci/mmconfig-shared.c | 44 +++++++++++++++++++++++++++++-----
 1 file changed, 38 insertions(+), 6 deletions(-)

--
2.25.1