linux-kernel - Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230112000521.GA3036960@paulmck-ThinkPad-P17-Gen-1>
Date:   Wed, 11 Jan 2023 16:05:21 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, rostedt@...dmis.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>, x86@...nel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"

On Tue, Jan 10, 2023 at 07:55:13PM +0000, Sean Christopherson wrote:
> On Mon, Jan 09, 2023, Paul E. McKenney wrote:
> > On Mon, Jan 09, 2023 at 11:22:28AM -0800, Paul E. McKenney wrote:
> > > On Mon, Jan 09, 2023 at 05:43:23PM +0000, Sean Christopherson wrote:
> > > > On Wed, Jan 04, 2023, Paul E. McKenney wrote:
> > > > > Now that the SRCU Kconfig option is unconditionally selected, there is
> > > > > no longer any point in selecting it.  Therefore, remove the "select SRCU"
> > > > > Kconfig statements.
> > > > > 
> > > > > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > > > > Cc: Thomas Gleixner <tglx@...utronix.de>
> > > > > Cc: Ingo Molnar <mingo@...hat.com>
> > > > > Cc: Borislav Petkov <bp@...en8.de>
> > > > > Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> > > > > Cc: "H. Peter Anvin" <hpa@...or.com>
> > > > > Cc: Sean Christopherson <seanjc@...gle.com>
> > > > > Cc: Paolo Bonzini <pbonzini@...hat.com>
> > > > > Cc: <x86@...nel.org>
> > > > > Cc: <kvm@...r.kernel.org>
> > > > > ---
> > > > 
> > > > ...
> > > > 
> > > > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > > > > index fbeaa9ddef598..9306d99585188 100644
> > > > > --- a/arch/x86/kvm/Kconfig
> > > > > +++ b/arch/x86/kvm/Kconfig
> > > > > @@ -46,7 +46,6 @@ config KVM
> > > > >  	select KVM_XFER_TO_GUEST_WORK
> > > > >  	select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > > > >  	select KVM_VFIO
> > > > > -	select SRCU
> > > > 
> > > > Would it be too much trouble to bundle all of the KVM changes into a single patch?
> > > > The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs
> > > > purely because of KVM's somewhat roundabout Kconfig setup.
> > > 
> > > No problem, and will do on my next rebase.  I might end up with a long
> > > list of Cc's, but so it goes.  I will of course send the result as a
> > > reply to this message.
> > 
> > Like this?
> 
> Ya, looks good!

Glad you like it!  May I have your ack?  Or would you take this one?

							Thanx, Paul