linux-kernel - Re: [PATCH 03/11] tty: vt: remove reference to undefined NO_VC_UNI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f40116d-d336-dd70-364e-70a8d7eef9a8@linux.intel.com>
Date:   Thu, 12 Jan 2023 10:44:37 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/11] tty: vt: remove reference to undefined
 NO_VC_UNI_SCREEN

On Thu, 12 Jan 2023, Jiri Slaby (SUSE) wrote:

> NO_VC_UNI_SCREEN is defined nowhere. Remove the last reference to it.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> ---
>  drivers/tty/vt/vt.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 7e5baf9f8ad8..561c82e120cf 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -495,9 +495,6 @@ int vc_uniscr_check(struct vc_data *vc)
>  	unsigned short *p;
>  	int x, y, mask;
>  
> -	if (__is_defined(NO_VC_UNI_SCREEN))
> -		return -EOPNOTSUPP;
> -
>  	WARN_CONSOLE_UNLOCKED();
>  
>  	if (!vc->vc_utf)
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.