linux-kernel - Re: [PATCH 2/4] ARM: pxa: remove further dead code after pxa93 support removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4d2f2b81-b7ab-4ad6-84cc-f3a3c932880d@app.fastmail.com>
Date:   Thu, 12 Jan 2023 10:05:47 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Lukas Bulwahn" <lukas.bulwahn@...il.com>
Cc:     "Aaro Koskinen" <aaro.koskinen@....fi>,
        "Janusz Krzysztofik" <jmkrzyszt@...il.com>,
        "Tony Lindgren" <tony@...mide.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-usb@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ARM: pxa: remove further dead code after pxa93 support removal

On Thu, Jan 12, 2023, at 09:37, Lukas Bulwahn wrote:
> Commit 150ccb6f9a89 ("ARM: pxa: remove pxa93x support") removes configs
> CPU_PXA930 and CPU_PXA935 and uses of cpu_is_pxa93x() and cpu_is_pxa935().
>
> Remove some further dead code in ./include/linux/soc/pxa/cpu.h on top of
> that commit above.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

I had this in an earlier version and ended up leaving this bit in
when I reworked the series to not drop support for PXA310 and PXA320.

You are probably right that we should not reference the removed
Kconfig symbols, but I see that this causes a regression
unless I also bring back the change to

drivers/mmc/host/pxamci.c:                              || cpu_is_pxa935())

    Arnd