linux-kernel - Re: [PATCH net-next] r8152; preserve device list format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7/fRlDqFRUOle7a@kroah.com>
Date:   Thu, 12 Jan 2023 11:21:58 +0100
From:   Greg KH <greg@...ah.com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Andre Przywara <andre.przywara@....com>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] r8152; preserve device list format

On Thu, Jan 12, 2023 at 11:18:59AM +0100, Bjørn Mork wrote:
> Greg KH <greg@...ah.com> writes:
> > On Thu, Jan 12, 2023 at 11:01:00AM +0100, Bjørn Mork wrote:
> >> This is a partial revert of commit ec51fbd1b8a2 ("r8152:
> >> add USB device driver for config selection")
> >> 
> >> Keep a simplified version of the REALTEK_USB_DEVICE macro
> >> to avoid unnecessary reformatting of the device list. This
> >> makes new device ID additions apply cleanly across driver
> >> versions.
> >> 
> >> Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
> >> Signed-off-by: Bjørn Mork <bjorn@...k.no>
> >> ---
> >> The patch in
> >> https://lore.kernel.org/lkml/20230111133228.190801-1-andre.przywara@arm.com/
> >> will apply cleanly on top of this.
> >> 
> >> This fix will also prevent a lot of stable backporting hassle.
> >
> > No need for this, just backport the original change to older kernels and
> > all will be fine.
> >
> > Don't live with stuff you don't want to because of stable kernels,
> > that's not how this whole process works at all :)
> 
> OK, thanks.  Will prepare a patch for stable instead then.
> 
> But I guess the original patch is unacceptable for stable as-is? It
> changes how Linux react to these devces, and includes a completely new
> USB device driver (i.e not interface driver).

That's up to you all.  We don't add new support for new hardware to
older kernels _UNLESS_ it's just a new device id.  Otherwise it's just
better to tell people to upgrade to the newer kernel.

If you split things up and added a whole new driver, then just leave it
alone, no need to backport anything, sorry, I didn't realize that.

greg k-h