linux-kernel - Re: [PATCH 5/5] vdpa: mlx5: support per virtqueue dma device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301120909.z8znuJ0g-lkp@intel.com>
Date:   Thu, 12 Jan 2023 10:07:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jason Wang <jasowang@...hat.com>, mst@...hat.com
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        elic@...dia.com, gdawar@....com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, tanuj.kamde@....com
Subject: Re: [PATCH 5/5] vdpa: mlx5: support per virtqueue dma device

Hi Jason,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.2-rc3 next-20230111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jason-Wang/virtio_ring-per-virtqueue-dma-device/20230111-143052
patch link:    https://lore.kernel.org/r/20230111062809.25020-6-jasowang%40redhat.com
patch subject: [PATCH 5/5] vdpa: mlx5: support per virtqueue dma device
config: x86_64-allmodconfig
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b7278272b70c83d953ebb0e5334dfc15c0b5c385
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jason-Wang/virtio_ring-per-virtqueue-dma-device/20230111-143052
        git checkout b7278272b70c83d953ebb0e5334dfc15c0b5c385
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ drivers/vdpa/mlx5/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/vdpa/mlx5/net/mlx5_vnet.c:2658:16: warning: no previous prototype for function 'mlx5_get_vq_dma_dev' [-Wmissing-prototypes]
   struct device *mlx5_get_vq_dma_dev(struct vdpa_device *vdev, u16 idx)
                  ^
   drivers/vdpa/mlx5/net/mlx5_vnet.c:2658:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct device *mlx5_get_vq_dma_dev(struct vdpa_device *vdev, u16 idx)
   ^
   static 
   1 warning generated.


vim +/mlx5_get_vq_dma_dev +2658 drivers/vdpa/mlx5/net/mlx5_vnet.c

  2657	
> 2658	struct device *mlx5_get_vq_dma_dev(struct vdpa_device *vdev, u16 idx)
  2659	{
  2660		struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
  2661	
  2662		if (is_ctrl_vq_idx(mvdev, idx))
  2663			return &vdev->dev;
  2664	
  2665		return mvdev->vdev.dma_dev;
  2666	}
  2667	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (286944 bytes)