[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <5ad677f3-2cbc-4ba0-bd48-2f832a72fb28@app.fastmail.com>
Date: Thu, 12 Jan 2023 15:24:51 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Hawkins, Nick" <nick.hawkins@....com>,
"Verdun, Jean-Marie" <verdun@....com>,
"Jean Delvare" <jdelvare@...e.com>,
"Guenter Roeck" <linux@...ck-us.net>,
"Rob Herring" <robh+dt@...nel.org>,
krzysztof.kozlowski+dt@...aro.org,
"Jonathan Corbet" <corbet@....net>,
"Russell King" <linux@...linux.org.uk>,
linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/5] ARM: dts: add GXP Support for fans and SPI
On Tue, Jan 3, 2023, at 21:36, nick.hawkins@....com wrote:
> From: Nick Hawkins <nick.hawkins@....com>
>
> Reorganize the base address of AHB to accommodate the SPI and fan driver
> register requirements. Add the hpe,gxp-spifi and hpe,gxp-fan-ctrl
> compatibles. Add comments to make the register range more clear.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@....com>
>
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi
> b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..b73b22a93716 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Device Tree file for HPE GXP
> + * Device Tree for HPE
> */
>
> /dts-v1/;
> @@ -52,76 +52,102 @@
> cache-level = <2>;
> };
>
> - ahb@...00000 {
> + ahb@...00000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x0 0xc0000000 0x30000000>;
> + ranges = <0x0 0x80000000 0xf000000>, /* 0x80000000 - 0x8f000000 */
> + <0x40000000 0xc0000000 0x7fffffff>; /* 0xc0000000 - 0xffffffff */
I'm a bit confused by the change in the mappings: are you
sure this all the same ahb bus and not two separate buses?
The comment for the second range looks wrong to me, as
you define a 2GB (minus one byte) sized mapping but the
comment only lists a 1GB (including the last byte) mapping.
I would expect that the original 0x30000000 (including the
last byte) was correct here.
> - vic1: interrupt-controller@...00000 {
> + vic1: interrupt-controller@...000 { /* 0x80f00000 */
This is not the same address as before. I'm also not sure the
comment is helpful here.
Arnd
Powered by blists - more mailing lists