[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAAEAJfDqXJf-UovhGnmN7FDY-skSu-x5Rgz+K2WVQP+PKUVbsQ@mail.gmail.com>
Date: Thu, 12 Jan 2023 12:02:31 -0300
From: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
To: Sebastian Fricke <sebastian.fricke@...labora.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev,
Jonas Karlman <jonas@...boo.se>,
Alex Bee <knaerzche@...il.com>,
Nicolas Dufresne <nicolas.dufresne@...labora.com>,
Collabora Kernel-domain <kernel@...labora.com>,
Robert Beckett <bob.beckett@...labora.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
Benjamin Gaignard <benjamin.gaignard@...labora.com>
Subject: Re: [PATCH v2 05/12] staging: media: rkvdec: Add SPS structure to
internal context
Hi Sebastian,
On Thu, Jan 12, 2023 at 9:56 AM Sebastian Fricke
<sebastian.fricke@...labora.com> wrote:
>
> Prepare storing the SPS structure for HEVC & H264 in the internal
> context of the rkvdec instance. This structure is used to figure out
> which capture queue format is appropriate for decoding.
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@...labora.com>
> ---
> drivers/staging/media/rkvdec/rkvdec.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h
> index 633335ebb9c4..332126e7b812 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.h
> +++ b/drivers/staging/media/rkvdec/rkvdec.h
> @@ -105,6 +105,7 @@ struct rkvdec_ctx {
> struct v4l2_ctrl_handler ctrl_hdl;
> struct rkvdec_dev *dev;
> void *priv;
> + void *sps;
I don't really like re-caching the SPS in the context,
since all the controls are already stored in the context,
via the ctrl_handler.
See hantro_get_ctrl().
Duplicating state can lead to problems and even if we get it
right this time, will be hard to maintain.
Thanks,
Ezequiel
> };
>
> static inline struct rkvdec_ctx *fh_to_rkvdec_ctx(struct v4l2_fh *fh)
>
> --
> 2.25.1
Powered by blists - more mailing lists