linux-kernel - Re: [PATCH] HID: add KEY_CAMERA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACOZ=ZU9mOj5Yr7_MJGjOH4wq2uRfXJt=QLZpD0SUQr9R4Vr=g@mail.gmail.com>
Date:   Thu, 12 Jan 2023 10:46:20 +0800
From:   qi feng <fengqi706@...il.com>
To:     jikos@...nel.org
Cc:     rydberg@...math.org, benjamin.tissoires@...hat.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        fengqi <fengqi@...omi.com>, lixiaojie5@...omi.com
Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

please help me review this code

thanks a lot

qi feng <fengqi706@...il.com> 于2023年1月10日周二 17:53写道：
>
> loop more
>
>
> Qi Feng <fengqi706@...il.com> 于2023年1月9日周一 20:32写道：
> >
> > From: fengqi <fengqi@...omi.com>
> >
> > Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> > event is non-existent in current HID driver.
> > So we add this event in hid-input.c
> >
> > Signed-off-by: fengqi <fengqi@...omi.com>
> > ---
> >  drivers/hid/hid-input.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 9b59e436df0a..22cca3406b5c 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> >                 case 0x0e5: map_key_clear(KEY_BASSBOOST);       break;
> >                 case 0x0e9: map_key_clear(KEY_VOLUMEUP);        break;
> >                 case 0x0ea: map_key_clear(KEY_VOLUMEDOWN);      break;
> > +               case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS);    break;
> >                 case 0x0f5: map_key_clear(KEY_SLOW);            break;
> >
> >                 case 0x181: map_key_clear(KEY_BUTTONCONFIG);    break;
> > --
> > 2.39.0
> >