[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7b7cd84a-e9ff-b2c1-4bf0-0ed05cca76bd@amd.com>
Date: Thu, 12 Jan 2023 09:31:43 -0600
From: Tom Lendacky <thomas.lendacky@....com>
To: Pierre Gondois <pierre.gondois@....com>,
linux-kernel@...r.kernel.org
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Florian Fainelli <f.fainelli@...il.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
Tsahee Zidenberg <tsahee@...apurnalabs.com>,
Antoine Tenart <atenart@...nel.org>,
Brijesh Singh <brijeshkumar.singh@....com>,
Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Khuong Dinh <khuong@...amperecomputing.com>,
Liviu Dudau <liviu.dudau@....com>,
Sudeep Holla <sudeep.holla@....com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
William Zhang <william.zhang@...adcom.com>,
Anand Gore <anand.gore@...adcom.com>,
Kursad Oney <kursad.oney@...adcom.com>,
Rafał Miłecki <rafal@...ecki.pl>,
Alim Akhtar <alim.akhtar@...sung.com>,
Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Chester Lin <clin@...e.com>,
Andreas Färber <afaerber@...e.de>,
Matthias Brugger <mbrugger@...e.com>,
NXP S32 Linux Team <s32@....com>,
Wei Xu <xuwei5@...ilicon.com>, Chanho Min <chanho.min@....com>,
Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Lars Povlsen <lars.povlsen@...rochip.com>,
Steen Hegelund <Steen.Hegelund@...rochip.com>,
Daniel Machon <daniel.machon@...rochip.com>,
UNGLinuxDriver@...rochip.com, Avi Fishman <avifishman70@...il.com>,
Tomer Maimon <tmaimon77@...il.com>,
Tali Perry <tali.perry1@...il.com>,
Patrick Venture <venture@...gle.com>,
Nancy Yuen <yuenn@...gle.com>,
Benjamin Fair <benjaminfair@...gle.com>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Heiko Stuebner <heiko@...ech.de>,
Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Jisheng Zhang <jszhang@...nel.org>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>,
Viorel Suman <viorel.suman@....com>,
Abel Vesa <abelvesa@...nel.org>,
Zhou Peng <eagle.zhou@....com>,
Shenwei Wang <shenwei.wang@....com>,
Ming Qian <ming.qian@....com>, Peng Fan <peng.fan@....com>,
Tim Harvey <tharvey@...eworks.com>,
Adam Ford <aford173@...il.com>,
Lucas Stach <l.stach@...gutronix.de>,
Richard Zhu <hongxing.zhu@....com>, Li Jun <jun.li@....com>,
Markus Niebel <Markus.Niebel@...tq-group.com>,
Joakim Zhang <qiangqing.zhang@....com>,
Marek Vasut <marex@...x.de>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Paul Elder <paul.elder@...asonboard.com>,
Alexander Stein <alexander.stein@...tq-group.com>,
Martin Kepplinger <martink@...teo.de>,
David Heidelberg <david@...t.cz>,
Liu Ying <victor.liu@....com>,
Oliver Graute <oliver.graute@...oconnector.com>,
Dong Aisheng <aisheng.dong@....com>,
Wei Fang <wei.fang@....com>,
Clark Wang <xiaoning.wang@....com>,
Jacky Bai <ping.bai@....com>,
Chris Packham <chris.packham@...iedtelesis.co.nz>,
Vadym Kochan <vadym.kochan@...ision.eu>,
Sameer Pujar <spujar@...dia.com>,
Prathamesh Shete <pshete@...dia.com>,
Mikko Perttunen <mperttunen@...dia.com>,
Akhil R <akhilrajeev@...dia.com>,
Sumit Gupta <sumitg@...dia.com>,
Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>,
Vidya Sagar <vidyas@...dia.com>,
Ashish Mhetre <amhetre@...dia.com>,
Johan Jonker <jbx6244@...il.com>,
Christopher Obbard <chris.obbard@...labora.com>,
Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
Aswani Reddy <aswani.reddy@...sung.com>,
Shashank Prashar <s.prashar@...sung.com>,
devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org,
linux-mediatek@...ts.infradead.org, openbmc@...ts.ozlabs.org,
linux-tegra@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-realtek-soc@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org,
linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 02/23] arm64: dts: Update cache properties for amd
On 11/7/22 09:56, Pierre Gondois wrote:
> The DeviceTree Specification v0.3 specifies that the cache node
> 'compatible' and 'cache-level' properties are 'required'. Cf.
> s3.8 Multi-level and Shared Cache Nodes
> The 'cache-unified' property should be present if one of the
> properties for unified cache is present ('cache-size', ...).
>
> Update the Device Trees accordingly.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
Acked-by: Tom Lendacky <thomas.lendacky@....com>
> ---
> arch/arm64/boot/dts/amd/amd-seattle-cpus.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amd/amd-seattle-cpus.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-cpus.dtsi
> index 93688a0b6820..9f2d983e082d 100644
> --- a/arch/arm64/boot/dts/amd/amd-seattle-cpus.dtsi
> +++ b/arch/arm64/boot/dts/amd/amd-seattle-cpus.dtsi
> @@ -163,38 +163,47 @@ CPU7: cpu@301 {
> };
>
> L2_0: l2-cache0 {
> + compatible = "cache";
> cache-size = <0x100000>;
> cache-line-size = <64>;
> cache-sets = <1024>;
> cache-unified;
> + cache-level = <2>;
> next-level-cache = <&L3>;
> };
>
> L2_1: l2-cache1 {
> + compatible = "cache";
> cache-size = <0x100000>;
> cache-line-size = <64>;
> cache-sets = <1024>;
> cache-unified;
> + cache-level = <2>;
> next-level-cache = <&L3>;
> };
>
> L2_2: l2-cache2 {
> + compatible = "cache";
> cache-size = <0x100000>;
> cache-line-size = <64>;
> cache-sets = <1024>;
> cache-unified;
> + cache-level = <2>;
> next-level-cache = <&L3>;
> };
>
> L2_3: l2-cache3 {
> + compatible = "cache";
> cache-size = <0x100000>;
> cache-line-size = <64>;
> cache-sets = <1024>;
> cache-unified;
> + cache-level = <2>;
> next-level-cache = <&L3>;
> };
>
> L3: l3-cache {
> + compatible = "cache";
> cache-level = <3>;
> cache-size = <0x800000>;
> cache-line-size = <64>;
Powered by blists - more mailing lists