linux-kernel - Re: [PATCH] clk: create write_enable file to control clk rate write and other dangerous ops permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <185a3f0a326.b623e6bd1243489.6765528573167668508@linux.beauty>
Date:   Thu, 12 Jan 2023 11:05:34 +0800
From:   Li Chen <me@...ux.beauty>
To:     "Stephen Boyd" <sboyd@...nel.org>
Cc:     "michael turquette" <mturquette@...libre.com>,
        "li chen" <lchen@...arella.com>,
        "linux-clk" <linux-clk@...r.kernel.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: create write_enable file to control clk rate write
 and other dangerous ops permission

Hi Stephen,
 ---- On Thu, 12 Jan 2023 02:37:29 +0800  Stephen Boyd  wrote --- 
 > Quoting Li Chen (2023-01-10 03:45:39)
 > > From: Li Chen lchen@...arella.com>
 > > 
 > > It's common requirement for bsp debug/test to change clk rate from userspace.
 > > 
 > > Currently, we must define CLKOCK_ALLOW_WRITE_DEBUGFS then re-compile kernel
 > > to allow this feature. Let's replace it with a "write_enable" file to
 > > allow enable it at runtime.
 > 
 > Nak. This design is intentional.
 
Thanks for your reply. Got it. But sometimes re-compile is somewhat low efficient. Is it acceptable to provide 
a write_enable to clk_core(not enable by default), and allow clk driver to enable it inside clk_ops->init
via clk_hw->core->write_enable = 1?

Regards,
Li