linux-kernel - Re: [PATCH] drm: amd: display: Fix memory leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b93c319e-b1c9-7488-7f0e-d96a6f98ad79@amd.com>
Date:   Thu, 12 Jan 2023 11:00:50 -0500
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@....com>
To:     Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        harry.wentland@....com
Cc:     sunpeng.li@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com,
        daniel@...ll.ch, Jun.Lei@....com, Alvin.Lee2@....com,
        meenakshikumar.somasundaram@....com, martin.leung@....com,
        Dillon.Varone@....com, wenjing.liu@....com, alex.hung@....com,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, yusongping@...wei.com,
        hukeping@...wei.com, artem.kuzin@...wei.com
Subject: Re: [PATCH] drm: amd: display: Fix memory leakage



On 11/29/22 21:50, Konstantin Meskhidze wrote:
> This commit fixes memory leakage in dc_construct_ctx() function.
> 
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 997ab031f816..359e28d3567e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -878,6 +878,7 @@ static bool dc_construct_ctx(struct dc *dc,
>   
>   	dc_ctx->perf_trace = dc_perf_trace_create();
>   	if (!dc_ctx->perf_trace) {
> +		kfree(dc_ctx);
>   		ASSERT_CRITICAL(false);
>   		return false;
>   	}

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>

And applied to amd-staging-drm-next.

Thanks
Siqueira