linux-kernel - Re: [PATCH v1 2/2] gpio: wcd934x: Use proper headers and drop OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 13 Jan 2023 10:53:03 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 2/2] gpio: wcd934x: Use proper headers and drop
 OF_GPIO dependency

Hi Andy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on brgl/gpio/for-next]
[also build test WARNING on linus/master v6.2-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpio-wcd934x-Use-proper-headers-and-drop-OF_GPIO-dependency/20230113-005747
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20230112163920.73102-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 2/2] gpio: wcd934x: Use proper headers and drop OF_GPIO dependency
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/7f9eb073b194585975007c28b381b96cd89b5c7a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/gpio-wcd934x-Use-proper-headers-and-drop-OF_GPIO-dependency/20230113-005747
        git checkout 7f9eb073b194585975007c28b381b96cd89b5c7a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-wcd934x.c:76:34: warning: 'struct platform_device' declared inside parameter list will not be visible outside of this definition or declaration
      76 | static int wcd_gpio_probe(struct platform_device *pdev)
         |                                  ^~~~~~~~~~~~~~~
   drivers/gpio/gpio-wcd934x.c: In function 'wcd_gpio_probe':
   drivers/gpio/gpio-wcd934x.c:78:35: error: invalid use of undefined type 'struct platform_device'
      78 |         struct device *dev = &pdev->dev;
         |                                   ^~
   drivers/gpio/gpio-wcd934x.c: At top level:
   drivers/gpio/gpio-wcd934x.c:114:15: error: variable 'wcd_gpio_driver' has initializer but incomplete type
     114 | static struct platform_driver wcd_gpio_driver = {
         |               ^~~~~~~~~~~~~~~
   drivers/gpio/gpio-wcd934x.c:115:10: error: 'struct platform_driver' has no member named 'driver'
     115 |         .driver = {
         |          ^~~~~~
   drivers/gpio/gpio-wcd934x.c:115:19: error: extra brace group at end of initializer
     115 |         .driver = {
         |                   ^
   drivers/gpio/gpio-wcd934x.c:115:19: note: (near initialization for 'wcd_gpio_driver')
   drivers/gpio/gpio-wcd934x.c:115:19: warning: excess elements in struct initializer
   drivers/gpio/gpio-wcd934x.c:115:19: note: (near initialization for 'wcd_gpio_driver')
   drivers/gpio/gpio-wcd934x.c:119:10: error: 'struct platform_driver' has no member named 'probe'
     119 |         .probe = wcd_gpio_probe,
         |          ^~~~~
   drivers/gpio/gpio-wcd934x.c:119:18: warning: excess elements in struct initializer
     119 |         .probe = wcd_gpio_probe,
         |                  ^~~~~~~~~~~~~~
   drivers/gpio/gpio-wcd934x.c:119:18: note: (near initialization for 'wcd_gpio_driver')
   drivers/gpio/gpio-wcd934x.c:122:1: warning: data definition has no type or storage class
     122 | module_platform_driver(wcd_gpio_driver);
         | ^~~~~~~~~~~~~~~~~~~~~~
   drivers/gpio/gpio-wcd934x.c:122:1: error: type defaults to 'int' in declaration of 'module_platform_driver' [-Werror=implicit-int]
   drivers/gpio/gpio-wcd934x.c:122:1: warning: parameter names (without types) in function declaration
   drivers/gpio/gpio-wcd934x.c:114:31: error: storage size of 'wcd_gpio_driver' isn't known
     114 | static struct platform_driver wcd_gpio_driver = {
         |                               ^~~~~~~~~~~~~~~
>> drivers/gpio/gpio-wcd934x.c:114:31: warning: 'wcd_gpio_driver' defined but not used [-Wunused-variable]
   cc1: some warnings being treated as errors


vim +/wcd_gpio_driver +114 drivers/gpio/gpio-wcd934x.c

59c324683400b4 Srinivas Kandagatla 2020-01-07  113  
59c324683400b4 Srinivas Kandagatla 2020-01-07 @114  static struct platform_driver wcd_gpio_driver = {
59c324683400b4 Srinivas Kandagatla 2020-01-07  115  	.driver = {
59c324683400b4 Srinivas Kandagatla 2020-01-07  116  		   .name = "wcd934x-gpio",
59c324683400b4 Srinivas Kandagatla 2020-01-07  117  		   .of_match_table = wcd_gpio_of_match,
59c324683400b4 Srinivas Kandagatla 2020-01-07  118  	},
59c324683400b4 Srinivas Kandagatla 2020-01-07  119  	.probe = wcd_gpio_probe,
59c324683400b4 Srinivas Kandagatla 2020-01-07  120  };
59c324683400b4 Srinivas Kandagatla 2020-01-07  121  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (294674 bytes)