linux-kernel - Re: [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Jan 2023 15:50:04 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 7/7] mm: swap: remove unneeded
 cgroup_throttle_swaprate()

On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote:
> All the callers of cgroup_throttle_swaprate() are converted to
> folio_throttle_swaprate(), so make __cgroup_throttle_swaprate()
> to take a folio, and drop unused cgroup_throttle_swaprate().

Shouldn't __cgroup_throttle_swaprate() then be called
__folio_throttle_swaprate()?

> +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask);

Also you can drop the 'extern'.

> +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask)

And it's not a gfp mask.  It's gfp_flags (we have this mistake all
through the mm).  Or you can just call it 'gfp'.