linux-kernel - Re: [PATCH v2 1/2] dt-bindings: leds: Convert PCA9532 to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Jan 2023 16:18:26 +0000
From:   Wadim Egorov <W.Egorov@...tec.de>
To:     Rob Herring <robh+dt@...nel.org>
CC:     "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "riku.voipio@....fi" <riku.voipio@....fi>,
        "pavel@....cz" <pavel@....cz>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "lee@...nel.org" <lee@...nel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "upstream@...ts.phytec.de" <upstream@...ts.phytec.de>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: Convert PCA9532 to dtschema

Am 11.01.23 um 19:51 schrieb Rob Herring:
> On Wed, Jan 11, 2023 at 12:47 PM Rob Herring <robh@...nel.org> wrote:
>>
>> On Wed, 11 Jan 2023 17:34:03 +0100, Wadim Egorov wrote:
>>> Convert the PCA9532 LED dimmer to dtschema.
>>> While at it, also update and the the example to match
>>> recommended node names and the link to the product datasheet.
>>>
>>> Signed-off-by: Wadim Egorov <w.egorov@...tec.de>
>>> ---
>>> v2:
>>>    - Rename yaml file to match compatibles, nxp,pca953x.yaml
>>>    - Remove Jacek Anaszewski from maintainers list
>>>    - Remove color labels in example
>>>    - Restore labels/default-states from original example
>>>    - Drop reg description
>>>    - Add unevaluatedProperties to patternProperties scope
>>>    - Update description of type property & set default to 0
>>>    - Fix indentation in example
>>> ---
>>>   .../devicetree/bindings/leds/leds-pca9532.txt | 49 -----------
>>>   .../devicetree/bindings/leds/nxp,pca953x.yaml | 85 +++++++++++++++++++
>>>   2 files changed, 85 insertions(+), 49 deletions(-)
>>>   delete mode 100644 Documentation/devicetree/bindings/leds/leds-pca9532.txt
>>>   create mode 100644 Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
>>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230111163404.3526248-1-w.egorov@phytec.de
>>
>>
>> leddimmer@62: 'led1', 'led2', 'led3', 'led4' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
>>          arch/arm/boot/dts/rk3288-phycore-rdk.dtb
>>
>> leds@62: 'led1', 'led2', 'led3' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
>>          arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb
>>
>> pca9530@61: 'tft-panel@0' does not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
>>          arch/arm/boot/dts/am335x-pdu001.dtb

How do I comply with the LED label warnings?
I am not sure about the proper convention. I was assuming led-<name> is correct.
The first two warnings can be fixed by dropping the '-' in the regex.
But I don't see how the last warning should comply with a proper LED node name. 
Or can this be ignored?

>>
>> pca9532@60: '#gpio-cells', 'gpio-controller' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
>>          arch/arm/boot/dts/lpc3250-ea3250.dtb
> Looks like GPIO properties need to be added as we have dts file and
> the driver supports GPIO. It's fine to add in the conversion, just
> mention it in the commit msg.

OK, thanks for pointing it out. I will add it in v3.

>
> Also, your 2 patches in the series are unrelated and go to different
> maintainers, so send them separately next time.

ok.

Regards,
Wadim

>
> Rob