linux-kernel - Re: linux-next: build warning after merge of the workqueues tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xhsmhzgamidp8.mognet@vschneid.remote.csb>
Date:   Fri, 13 Jan 2023 16:47:31 +0000
From:   Valentin Schneider <vschneid@...hat.com>
To:     Tejun Heo <tj@...nel.org>, Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the workqueues tree

On 13/01/23 06:31, Tejun Heo wrote:
> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the workqueues tree, today's linux-next build (x86_64
>> allnoconfig and several others) produced this warning:
>>
>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function]
>>  1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool)
>>       |             ^~~~~~~~~~~~~
>>
>> Introduced by commit
>>
>>   793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic")
>
> Valentin, this is caused by rebind_worker() being only used by
> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of
> rebind_worker(). Just fold it back into rebind_workers()?
>

Woops! Yes I only did it to keep things aligned with unbind_workers(), let
me resend with that folded back in. Sorry!

> Thanks.
>
> --
> tejun