linux-kernel - Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points int340x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a5ea6ac492d354479f5d340c16588f2f4b3d7c0.camel@linux.intel.com>
Date:   Fri, 13 Jan 2023 09:34:09 -0800
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        "rafael@...nel.org" <rafael@...nel.org>
Cc:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "daniel.lezcano@...nel.org" <daniel.lezcano@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "amitk@...nel.org" <amitk@...nel.org>
Subject: Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points
 int340x

On Fri, 2023-01-13 at 18:21 +0100, Daniel Lezcano wrote:
> 
> Hi Srinivas,
> 
> On 13/01/2023 16:48, srinivas pandruvada wrote:
> > Hi Daniel,
> > 
> > > > > 
> > 
> > [...]
> > 
> > > > > -       status = acpi_evaluate_integer(d->adev->handle,
> > > > > "GTSH",
> > > > > NULL,
> > > > > &hyst);
> > > > > -       if (ACPI_FAILURE(status))
> > > > > -               *temp = 0;
> > > > > -       else
> > > > > -               *temp = hyst * 100;
> > > > 
> > > > The previous code returns hyst * 100.
> > > > But the new API retuurns hyst directly.
> > > > 
> > > > -/sys/class/thermal/thermal_zone2/trip_point_4_hyst:2000
> > > > +/sys/class/the
> > > > rmal/thermal_zone2/trip_point_4_hyst:20
> > > > 
> > > > Is this done on purpose?
> > > 
> > > No, it is an error. The function thermal_acpi_trip_gtsh() should
> > > do:
> > > 
> > >          return deci_kelvin_to_millicelsius(hyst);
> > > 
> > > 
> > 
> > GTSH returns here in tenths of degree Kelvin. For example 15 means
> > 1.5
> > degree K.
> 
> Yes, so the above conversion is correct, right ?
Correct.

Thanks,
Srinivas

> 
> > I would like to test your next series with thermald. If there is a
> > problem, it will break every distro.
> 
> Great, thanks!
> 
>