[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b79f7e0a-8048-d0e1-ad0b-d15d72288fde@amd.com>
Date: Fri, 13 Jan 2023 10:08:19 -0800
From: Tanmay Shah <tanmays@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Tanmay Shah <tanmay.shah@....com>, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: sram: Tightly Coupled Memory (TCM) bindings
On 1/12/23 11:52 PM, Krzysztof Kozlowski wrote:
> On 13/01/2023 08:30, Tanmay Shah wrote:
>> This patch introduces bindings for TCM memory address space on AMD-xilinx
>> platforms. As of now TCM addresses are hardcoded in xilinx remoteproc
>> driver. This bindings will help in defining TCM in device-tree and
>> make it's access platform agnostic and data-driven from the driver.
>>
> Subject: drop second/last, redundant "bindings". The "dt-bindings"
> prefix is already stating that these are bindings.
Ack.
>
> Where is driver or DTS? Are you now adding a dead binding without users?
TCM is used by drivers/remoteproc/xlnx_r5_remoteproc.c driver. Howerver,
we have hardcode addresses in TCM as bindings are not available yet.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists