linux-kernel - Re: [PATCH v2 2/2] dt-bindings: rtc: Move rv3028 from trivial-rtc.yaml into own schema file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230113192504.GA2800695-robh@kernel.org>
Date:   Fri, 13 Jan 2023 13:25:04 -0600
From:   Rob Herring <robh@...nel.org>
To:     Wadim Egorov <w.egorov@...tec.de>
Cc:     linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        upstream@...ts.phytec.de, riku.voipio@....fi,
        alexandre.belloni@...tlin.com, a.zummo@...ertech.it,
        krzysztof.kozlowski+dt@...aro.org, lee@...nel.org, pavel@....cz
Subject: Re: [PATCH v2 2/2] dt-bindings: rtc: Move rv3028 from
 trivial-rtc.yaml into own schema file

On Wed, Jan 11, 2023 at 05:34:04PM +0100, Wadim Egorov wrote:
> Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml.

That's obvious from the diff. What's not obvious is 'why' and the commit 
message should answer that. I assume something about it makes it not 
trivial.

> 
> Signed-off-by: Wadim Egorov <w.egorov@...tec.de>
> ---
> v2:
>   - Update subject 
>   - Remove not needed quotes
>   - Remove start-year
>   - Use unevaluatedProperties instead of additionalProperties
> ---
>  .../bindings/rtc/microcrystal,rv3028.yaml     | 54 +++++++++++++++++++
>  .../devicetree/bindings/rtc/trivial-rtc.yaml  |  2 -
>  2 files changed, 54 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml

Otherwise,

Reviewed-by: Rob Herring <robh@...nel.org>