linux-kernel - Re: [lvc-project] [PATCH] iio: chemical: scd30: Add check for NULL in scd30_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15a05909-a373-09af-c0bf-1b35fd019bd5@ispras.ru>
Date:   Fri, 13 Jan 2023 22:27:44 +0300
From:   Alexey Khoroshilov <khoroshilov@...ras.ru>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Anastasia Belova <abelova@...ralinux.ru>,
        Tomasz Duszynski <tomasz.duszynski@...akon.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        lvc-project@...uxtesting.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>
Subject: Re: [lvc-project] [PATCH] iio: chemical: scd30: Add check for NULL in
 scd30_i2c_command

On 13.01.2023 21:47, Andy Shevchenko wrote:
> On Fri, Jan 13, 2023 at 8:41 PM Alexey Khoroshilov
> <khoroshilov@...ras.ru> wrote:
>> On 13.01.2023 16:33, Anastasia Belova wrote:
> 
>> It seems it is better to put the whole validation loop under if (rsp)
>> check.
> 
> No. The entire patch is redundant.
> The code that calls this function is under the control of the same
> driver, so we know how to avoid shooting in our foot.

I see, there is an assumption that response is NULL iff size is zero.

May be it could be documented, because naming of arguments does not make
such assumption obvious for fresh readers.

--
Thank you,
Alexey