linux-kernel - Re: [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230113194208.GE4028633@paulmck-ThinkPad-P17-Gen-1>
Date:   Fri, 13 Jan 2023 11:42:08 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, rostedt@...dmis.org,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Borislav Petkov <bp@...e.de>,
        Alan Stern <stern@...land.harvard.edu>,
        John Ogness <john.ogness@...utronix.de>
Subject: Re: [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU

On Fri, Jan 13, 2023 at 12:25:48PM +0100, Wysocki, Rafael J wrote:
> 
> On 1/13/2023 1:11 AM, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in conditional compilation based on CONFIG_SRCU.
> > Therefore, remove the #ifdef.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> > Cc: "Michał Mirosław" <mirq-linux@...e.qmqm.pl>
> > Cc: Borislav Petkov <bp@...e.de>
> > Cc: Alan Stern <stern@...land.harvard.edu>
> > Reviewed-by: John Ogness <john.ogness@...utronix.de>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Thank you!  I will apply both of your acks on my next rebase.

							Thanx, Paul

> > ---
> >   kernel/notifier.c | 3 ---
> >   1 file changed, 3 deletions(-)
> > 
> > diff --git a/kernel/notifier.c b/kernel/notifier.c
> > index ab75637fd904f..d353e4b5402d7 100644
> > --- a/kernel/notifier.c
> > +++ b/kernel/notifier.c
> > @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh,
> >   }
> >   EXPORT_SYMBOL_GPL(raw_notifier_call_chain);
> > -#ifdef CONFIG_SRCU
> >   /*
> >    *	SRCU notifier chain routines.    Registration and unregistration
> >    *	use a mutex, and call_chain is synchronized by SRCU (no locks).
> > @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh)
> >   }
> >   EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
> > -#endif /* CONFIG_SRCU */
> > -
> >   static ATOMIC_NOTIFIER_HEAD(die_chain);
> >   int notrace notify_die(enum die_val val, const char *str,