linux-kernel - Re: [PATCH v6 2/8] cxl/mem: Wire up event interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8HRFjA0bQKw/yoZ@iweiny-mobl>
Date:   Fri, 13 Jan 2023 13:45:58 -0800
From:   Ira Weiny <ira.weiny@...el.com>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
CC:     Dan Williams <dan.j.williams@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Alison Schofield <alison.schofield@...el.com>,
        "Vishal Verma" <vishal.l.verma@...el.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Dave Jiang" <dave.jiang@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        "Steven Rostedt" <rostedt@...dmis.org>,
        <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>
Subject: Re: [PATCH v6 2/8] cxl/mem: Wire up event interrupts

On Fri, Jan 13, 2023 at 12:28:45PM +0000, Jonathan Cameron wrote:
> On Mon, 09 Jan 2023 11:42:21 -0800
> ira.weiny@...el.com wrote:
> 
> > From: Davidlohr Bueso <dave@...olabs.net>
> > 
> > Currently the only CXL features targeted for irq support require their
> > message numbers to be within the first 16 entries.  The device may
> > however support less than 16 entries depending on the support it
> > provides.
> > 
> > Attempt to allocate these 16 irq vectors.  If the device supports less
> > then the PCI infrastructure will allocate that number.  Upon successful
> > allocation, users can plug in their respective isr at any point
> > thereafter.
> > 
> > CXL device events are signaled via interrupts.  Each event log may have
> > a different interrupt message number.  These message numbers are
> > reported in the Get Event Interrupt Policy mailbox command.
> > 
> > Add interrupt support for event logs.  Interrupts are allocated as
> > shared interrupts.  Therefore, all or some event logs can share the same
> > message number.
> > 
> > In addition all logs are queried on any interrupt in order of the most
> > to least severe based on the status register.
> > 
> > Finally place all event configuration logic into cxl_event_config().
> > Previously the logic was a simple 'read all' on start up.  But
> > interrupts must be configured prior to any reads to ensure no events are
> > missed.  A single event configuration function results in a cleaner over
> > all implementation.
> > 
> > Cc: Bjorn Helgaas <helgaas@...nel.org>
> > Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> > Co-developed-by: Ira Weiny <ira.weiny@...el.com>
> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> > Signed-off-by: Davidlohr Bueso <dave@...olabs.net>
> 
> > 
> > ---
> > Changes from V5:
> > 	Dan
> > 		Addressed missed comments on V4
> > 		https://lore.kernel.org/all/6398dd6ed80fa_b05d1294fc@dwillia2-xfh.jf.intel.com.notmuch/
> 
> You also added pci_set_master() :)

<sigh> Yes I made the mistake of putting that note in another patch and then
when I fixed it up I dropped it from here.

> 
> Which means I can now give
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Thanks!

> 
> I only noticed because I couldn't remember why I'd not given a tag to v4.

Sorry I'm working on getting a better workflow.
Ira

> 
> Jonathan
>