linux-kernel - Re: [PATCH 3/4] tracing: Add trace_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 19:00:30 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Ross Zwisler <zwisler@...gle.com>
Cc:     linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 3/4] tracing: Add trace_array_puts() to write into
 instance

On Thu, 12 Jan 2023 16:26:27 -0700
Ross Zwisler <zwisler@...gle.com> wrote:

> > +/**
> > + * trace_array_puts - write a constant string into the trace buffer.
> > + * @tr:    The trace array to write to
> > + * @ip:	   The address of the caller  
> 
> @ip is not an arg to trace_array_puts(), an can be dropped from the comment.

Good catch.

My first version had it, and then I realized I didn't like it (to be in
sync with the internal version of __trace_puts()". But I forgot to update
the kernel doc. Thanks for pointing that out.

> 
> Other than that, you can add:
> 
> Reviewed-by: Ross Zwisler <zwisler@...gle.com>

Thanks,

-- Steve