linux-kernel - Re: [PATCH] USB: serial: option: add Quectel EM05CN modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8EJAN5hf8a8Bj8H@hovoldconsulting.com>
Date:   Fri, 13 Jan 2023 08:32:16 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Duke Xin(辛安文) <duke_xinanwen@....com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, jerry.meng@...ctel.com,
        duke.xin@...ctel.com
Subject: Re: [PATCH] USB: serial: option: add Quectel EM05CN modem

On Thu, Jan 12, 2023 at 10:27:39PM -0800, Duke Xin(辛安文) wrote:
> The EM05CN modem has 2 USB configurations that are configurable via the AT
> command AT+QCFG="usbnet",[ 0 | 2 ] which make the modem enumerate with
> the following interfaces, respectively:
> 
> "MBIM"  : AT + MBIM + DIAG + NMEA  + MODEM
> "RMNET" : AT + DIAG + NMEA + Modem + QMI

Thanks for the update. When sending a new revision of patch, make sure
to include a version number in Subject (e.g. in this case "[PATCH v2]
USB: serial: ...).

Also add short changelog below the --- line (so that it doesn't end up
in the git logs).

You again sent two patches with identical Subject adding different
devices. Please add the variant in parenthesis or similar so that we can
tell them apart (e.g. "EM05CN (SG)").

Can you fix that up in a v3 (for both of these patches)?

> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@....com>
> ---

Johan