linux-kernel - Re: [PATCH 5.15.y 2/4] phy: qcom-qmp-combo: fix memleak on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8EO8w9Smn4NAox6@hovoldconsulting.com>
Date:   Fri, 13 Jan 2023 08:57:39 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     stable@...r.kernel.org, Johan Hovold <johan+linaro@...nel.org>,
        linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH 5.15.y 2/4] phy: qcom-qmp-combo: fix memleak on probe
 deferral

On Thu, Jan 12, 2023 at 04:54:03PM -0800, Stephen Boyd wrote:
> From: Johan Hovold <johan+linaro@...nel.org>
> 
> commit 2de8a325b1084330ae500380cc27edc39f488c30 upstream.
> 
> Switch to using the device-managed of_iomap helper to avoid leaking
> memory on probe deferral and driver unbind.
> 
> Note that this helper checks for already reserved regions and may fail
> if there are multiple devices claiming the same memory.

This bit turned out to catch some buggy bindings and dts, so if you want
to backport this one then the corresponding fixes for that would be
needed as well.

That includes

	a5d6b1ac56cb ("phy: qcom-qmp-usb: fix memleak on probe deferral")

and some dts fixes which likely already have been backported.

It may even be preferred to keep to just skip this patch and keep those
small memory leaks on probe deferral to not risk any regressions in
stable.

> Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> Link: https://lore.kernel.org/r/20220916102340.11520-5-johan+linaro@kernel.org
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Johan