linux-kernel - Re: [PATCH -next V14 4/7] riscv: entry: Convert to generic entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8EjAt3DC4WC062n@wendy>
Date:   Fri, 13 Jan 2023 09:23:14 +0000
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     <guoren@...nel.org>
CC:     <arnd@...db.de>, <palmer@...osinc.com>, <tglx@...utronix.de>,
        <peterz@...radead.org>, <luto@...nel.org>, <heiko@...ech.de>,
        <jszhang@...nel.org>, <lazyparser@...il.com>, <falcon@...ylab.org>,
        <chenhuacai@...nel.org>, <apatel@...tanamicro.com>,
        <atishp@...shpatra.org>, <mark.rutland@....com>,
        <ben@...adent.org.uk>, <bjorn@...nel.org>,
        <linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>,
        Guo Ren <guoren@...ux.alibaba.com>,
        Björn Töpel <bjorn@...osinc.com>,
        Yipeng Zou <zouyipeng@...wei.com>
Subject: Re: [PATCH -next V14 4/7] riscv: entry: Convert to generic entry

Hey Guo Ren,

On Thu, Jan 12, 2023 at 04:58:45AM -0500, guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> This patch converts riscv to use the generic entry infrastructure from
> kernel/entry/*. The generic entry makes maintainers' work easier and
> codes more elegant. Here are the changes:
> 
>  - More clear entry.S with handle_exception and ret_from_exception
>  - Get rid of complex custom signal implementation
>  - Move syscall procedure from assembly to C, which is much more
>    readable.
>  - Connect ret_from_fork & ret_from_kernel_thread to generic entry.
>  - Wrap with irqentry_enter/exit and syscall_enter/exit_from_user_mode
>  - Use the standard preemption code instead of custom
> 
> Suggested-by: Huacai Chen <chenhuacai@...nel.org>
> Reviewed-by: Björn Töpel <bjorn@...osinc.com>
> Tested-by: Yipeng Zou <zouyipeng@...wei.com>
> Tested-by: Jisheng Zhang <jszhang@...nel.org>
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@...nel.org>
> Cc: Ben Hutchings <ben@...adent.org.uk>

Unfortunately from this patch onwards, the !MMU build is broken.
Should be able to reproduce it with nommu_virt_defconfig.

Thanks,
Conor.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)