[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2f653f1c-161c-57d2-b3c7-f21ded261938@paragon-software.com>
Date: Fri, 13 Jan 2023 13:44:48 +0400
From: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To: Shigeru Yoshida <syoshida@...hat.com>
CC: <ntfs3@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/ntfs3: Fix error handling in ntfs_new_inode()
On 04.01.2023 16:39, Shigeru Yoshida wrote:
> When memory allocation for mi->mrec fails, ntfs_new_inode() calls
> iput(). iput() calls ni_write_inode() indirectly, it references
> uninitialized mi->mrec, and this causes the kernel crash. This patch
> fixes the issue by making the inode bad before calling iput().
>
> Signed-off-by: Shigeru Yoshida <syoshida@...hat.com>
> ---
> fs/ntfs3/fsntfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
> index 567563771bf8..7b93f2aeb6f6 100644
> --- a/fs/ntfs3/fsntfs.c
> +++ b/fs/ntfs3/fsntfs.c
> @@ -1683,6 +1683,7 @@ struct ntfs_inode *ntfs_new_inode(struct ntfs_sb_info *sbi, CLST rno, bool dir)
>
> out:
> if (err) {
> + _ntfs_bad_inode(inode);
> iput(inode);
> ni = ERR_PTR(err);
> }
Hello.
This bug have been already fixed by Ye Bin
(https://lore.kernel.org/lkml/20221117091912.3436127-1-yebin@huaweicloud.com/).
* Thanks for your work.
Powered by blists - more mailing lists