linux-kernel - Re: [PATCH net-next] r8152; preserve device list format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Jan 2023 11:16:47 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Greg KH <greg@...ah.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Andre Przywara <andre.przywara@....com>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] r8152; preserve device list format

Greg KH <greg@...ah.com> writes:
> On Thu, Jan 12, 2023 at 11:29:40AM +0100, Bjørn Mork wrote:
>> Bjørn Mork <bjorn@...k.no> writes:
>> > Greg KH <greg@...ah.com> writes:
>> >
>> >> No need for this, just backport the original change to older kernels and
>> >> all will be fine.
>> >>
>> >> Don't live with stuff you don't want to because of stable kernels,
>> >> that's not how this whole process works at all :)
>> >
>> > OK, thanks.  Will prepare a patch for stable instead then.
>> >
>> > But I guess the original patch is unacceptable for stable as-is? It
>> > changes how Linux react to these devces, and includes a completely new
>> > USB device driver (i.e not interface driver).
>> 
>> Doh!  I gotta start thinking before I send email.  Will start right
>> after sending this one ;-)
>> 
>> We cannot backport the device-id table change to stable without taking
>> the rest of the patch. The strategy used by the old driver needs two
>> entries per device ID, which is why the macro was there.
>> 
>> So the question is: Can commit ec51fbd1b8a2 ("r8152: add USB device
>> driver for config selection") be accepted in stable?
>> 
>> ( Direct link for convenience since it's not yet in mainline:
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/usb/r8152.c?id=ec51fbd1b8a2bca2948dede99c14ec63dc57ff6b
>> )
>> 
>> This is not within the rules as I read them, but it's your call...
>
> Ah, yeah, that's simple enough, I'd take it if you send it to me :)

Great!

There is no point backporting to anything older than v5.15 since the
patch depend on significant driver changes between v5.10 and v5.15.  The
good news is that those changes also modified the macro in question so
any device ID patch for v5.10 or older will have to be fixed up in any
case.  So we don't lose anything by ignoring the older longterm kernels
here.

IIUC the special netdev stable rules are gone.  But if this is going to
stable, then I believe it still has to go to "net" first.

David/Jakub - Would you please pick

  ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
  69649ef84053 ("cdc_ether: no need to blacklist any r8152 devices")

from net-next to net?  With a "CC: stable" preferably.  Or do you prefer
some other solution?



Bjørn