linux-kernel - Re: [PATCH rcu v2 09/20] fs: Remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 20:03:48 -0500
From:   Jeff Layton <jlayton@...nel.org>
To:     "Paul E. McKenney" <paulmck@...nel.org>, rcu@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-team@...a.com,
        rostedt@...dmis.org, Chuck Lever <chuck.lever@...cle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org,
        John Ogness <john.ogness@...utronix.de>
Subject: Re: [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU

On Thu, 2023-01-12 at 16:11 -0800, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in conditional compilation based on CONFIG_SRCU.
> Therefore, remove the #ifdef and throw away the #else clause.
> 
> Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> Cc: Jeff Layton <jlayton@...nel.org>
> Cc: Chuck Lever <chuck.lever@...cle.com>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: <linux-fsdevel@...r.kernel.org>
> Reviewed-by: John Ogness <john.ogness@...utronix.de>
> ---
>  fs/locks.c | 25 -------------------------
>  1 file changed, 25 deletions(-)
> 
> diff --git a/fs/locks.c b/fs/locks.c
> index 8f01bee177159..1909a9de242c8 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -1889,7 +1889,6 @@ int generic_setlease(struct file *filp, long arg, struct file_lock **flp,
>  }
>  EXPORT_SYMBOL(generic_setlease);
>  
> -#if IS_ENABLED(CONFIG_SRCU)
>  /*
>   * Kernel subsystems can register to be notified on any attempt to set
>   * a new lease with the lease_notifier_chain. This is used by (e.g.) nfsd
> @@ -1923,30 +1922,6 @@ void lease_unregister_notifier(struct notifier_block *nb)
>  }
>  EXPORT_SYMBOL_GPL(lease_unregister_notifier);
>  
> -#else /* !IS_ENABLED(CONFIG_SRCU) */
> -static inline void
> -lease_notifier_chain_init(void)
> -{
> -}
> -
> -static inline void
> -setlease_notifier(long arg, struct file_lock *lease)
> -{
> -}
> -
> -int lease_register_notifier(struct notifier_block *nb)
> -{
> -	return 0;
> -}
> -EXPORT_SYMBOL_GPL(lease_register_notifier);
> -
> -void lease_unregister_notifier(struct notifier_block *nb)
> -{
> -}
> -EXPORT_SYMBOL_GPL(lease_unregister_notifier);
> -
> -#endif /* IS_ENABLED(CONFIG_SRCU) */
> -
>  /**
>   * vfs_setlease        -       sets a lease on an open file
>   * @filp:	file pointer

Reviewed-by: Jeff Layton <jlayton@...nel.org>