linux-kernel - Re: [PATCH 1/1] PCI: Add translated request only opt-in for pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ae3f5d2-1b58-7498-656d-696182a3589f@linux.intel.com>
Date:   Fri, 13 Jan 2023 09:56:17 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     baolu.lu@...ux.intel.com, Jason Gunthorpe <jgg@...dia.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Joerg Roedel <jroedel@...e.de>,
        Christian König <christian.koenig@....com>,
        Kevin Tian <kevin.tian@...el.com>,
        Vasant Hegde <vasant.hegde@....com>,
        Tony Zhu <tony.zhu@...el.com>, linux-pci@...r.kernel.org,
        iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Matt Fagnani <matt.fagnani@...l.net>
Subject: Re: [PATCH 1/1] PCI: Add translated request only opt-in for
 pci_enable_pasid()

On 2023/1/13 2:34, Bjorn Helgaas wrote:
> On Thu, Jan 12, 2023 at 09:25:25PM +0800, Baolu Lu wrote:
>> On 2023/1/12 20:38, Jason Gunthorpe wrote:
>>> On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:
>>>
>>>> -int pci_enable_pasid(struct pci_dev *pdev, int features);
>>>> +int pci_enable_pasid(struct pci_dev *pdev, int features, bool
>>>> transled_only);
>        ^^^^^^^^
> 
>> + * @flags: device-specific flags
>> + *   - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID
>> + *                                  memory requests of translated type.
>                      ^^^^^^^^
> 
> I don't like "transled" since it's not a word itself or an obvious
> combination of "translated" and something else.
> 
> Not sure whether you need to abbreviate it, but if you do, "xlate" is
> a common shortening of "translate".

Yes. "xlate" looks better. I will replace with it.

I've updated this patch with a v2.

https://lore.kernel.org/linux-iommu/20230113014409.752405-1-baolu.lu@linux.intel.com/

Thank you both for the comments.

--
Best regards,
baolu